Skip to content

Commit

Permalink
Merge pull request #37552 from frappe/addr_fetch
Browse files Browse the repository at this point in the history
fix: Ignore addr permission in internal code
  • Loading branch information
ankush authored Oct 17, 2023
2 parents f900a78 + 7b9cede commit 0931e93
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions erpnext/controllers/selling_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import frappe
from frappe import _, bold, throw
from frappe.contacts.doctype.address.address import get_address_display
from frappe.utils import cint, flt, get_link_to_form, nowtime

from erpnext.controllers.accounts_controller import get_taxes_and_charges
Expand Down Expand Up @@ -593,6 +592,12 @@ def set_gross_profit(self):
)

def set_customer_address(self):
try:
from frappe.contacts.doctype.address.address import render_address
except ImportError:
# Older frappe versions where this function is not available
from frappe.contacts.doctype.address.address import get_address_display as render_address

address_dict = {
"customer_address": "address_display",
"shipping_address_name": "shipping_address",
Expand All @@ -602,7 +607,8 @@ def set_customer_address(self):

for address_field, address_display_field in address_dict.items():
if self.get(address_field):
self.set(address_display_field, get_address_display(self.get(address_field)))
address = frappe.call(render_address, self.get(address_field), ignore_permissions=True)
self.set(address_display_field, address)

def validate_for_duplicate_items(self):
check_list, chk_dupl_itm = [], []
Expand Down

0 comments on commit 0931e93

Please sign in to comment.