refactor: ignore malformed json

frappe · Dec 13, 2024 · 0a7b0b1 · 0a7b0b1
1 parent 14a5779
commit 0a7b0b1
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/erpnext/patches/v15_0/migrate_old_item_wise_tax_detail_data_format.py b/erpnext/patches/v15_0/migrate_old_item_wise_tax_detail_data_format.py
@@ -30,9 +30,8 @@ def execute():
 				item_iterator = json.loads(doc.item_wise_tax_detail).items()
 			except AttributeError as e:
 				# This is stale data from 2009 found in a database
-				if json.loads(doc.item_wise_tax_detail) == 1:
-					# meaning: replace with an empty {}
-					needs_update = True
+				if isinstance(json.loads(doc.item_wise_tax_detail), int | float):
+					needs_update = False
 				else:
 					raise e
 			else: