Skip to content

Commit

Permalink
chore: change f-string to sql params
Browse files Browse the repository at this point in the history
  • Loading branch information
rtdany10 committed Nov 21, 2023
1 parent bfaa93b commit 383a4b1
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions erpnext/accounts/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,18 +282,22 @@ def get_balance_on(
cond.append("""gle.company = %s """ % (frappe.db.escape(company, percent=False)))

if account or (party_type and party) or account_type:
precision = get_currency_precision()
precision = frappe.db.escape(get_currency_precision())
if in_account_currency:
select_field = f"sum(round(debit_in_account_currency, {precision})) - sum(round(credit_in_account_currency, {precision}))"
select_field = (
"sum(round(debit_in_account_currency, %s)) - sum(round(credit_in_account_currency, %s))"
)
else:
select_field = f"sum(round(debit, {precision})) - sum(round(credit, {precision}))"
select_field = "sum(round(debit, %s)) - sum(round(credit, %s))"

bal = frappe.db.sql(
"""
SELECT {0}
FROM `tabGL Entry` gle
WHERE {1}""".format(
select_field, " and ".join(cond)
)
),
(precision, precision),
)[0][0]
# if bal is None, return 0
return flt(bal)
Expand Down

0 comments on commit 383a4b1

Please sign in to comment.