Skip to content

Commit

Permalink
perf: too many writes error during reposting (backport #43978) (#43982)
Browse files Browse the repository at this point in the history
perf: too many writes error during reposting (#43978)

perf: too many writes error
(cherry picked from commit 134c24b)

Co-authored-by: rohitwaghchaure <[email protected]>
  • Loading branch information
mergify[bot] and rohitwaghchaure authored Nov 6, 2024
1 parent 1e2bea8 commit 57d35ec
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions erpnext/stock/stock_ledger.py
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ def get_incoming_outgoing_rate_from_transaction(self, sle):
rate = 0
# Material Transfer, Repack, Manufacturing
if sle.voucher_type == "Stock Entry":
self.recalculate_amounts_in_stock_entry(sle.voucher_no)
self.recalculate_amounts_in_stock_entry(sle.voucher_no, sle.voucher_detail_no)
rate = frappe.db.get_value("Stock Entry Detail", sle.voucher_detail_no, "valuation_rate")
# Sales and Purchase Return
elif sle.voucher_type in (
Expand Down Expand Up @@ -853,14 +853,15 @@ def update_rate_on_stock_entry(self, sle, outgoing_rate):

# Update outgoing item's rate, recalculate FG Item's rate and total incoming/outgoing amount
if not sle.dependant_sle_voucher_detail_no:
self.recalculate_amounts_in_stock_entry(sle.voucher_no)
self.recalculate_amounts_in_stock_entry(sle.voucher_no, sle.voucher_detail_no)

def recalculate_amounts_in_stock_entry(self, voucher_no):
def recalculate_amounts_in_stock_entry(self, voucher_no, voucher_detail_no):
stock_entry = frappe.get_doc("Stock Entry", voucher_no, for_update=True)
stock_entry.calculate_rate_and_amount(reset_outgoing_rate=False, raise_error_if_no_rate=False)
stock_entry.db_update()
for d in stock_entry.items:
d.db_update()
if d.name == voucher_detail_no or (not d.s_warehouse and d.t_warehouse):
d.db_update()

def update_rate_on_delivery_and_sales_return(self, sle, outgoing_rate):
# Update item's incoming rate on transaction
Expand Down

0 comments on commit 57d35ec

Please sign in to comment.