Skip to content

Commit

Permalink
Merge pull request #39616 from GursheenK/item-delivery-date-from-qtn
Browse files Browse the repository at this point in the history
fix(minor): do not auto-populate item delivery date from qtn
  • Loading branch information
GursheenK authored Jan 29, 2024
2 parents efade9b + 079cd30 commit 866df9f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion erpnext/selling/doctype/quotation/quotation.py
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,6 @@ def update_item(obj, target, source_parent):
balance_qty = obj.qty - ordered_items.get(obj.item_code, 0.0)
target.qty = balance_qty if balance_qty > 0 else 0
target.stock_qty = flt(target.qty) * flt(obj.conversion_factor)
target.delivery_date = nowdate()

if obj.against_blanket_order:
target.against_blanket_order = obj.against_blanket_order
Expand Down
2 changes: 0 additions & 2 deletions erpnext/selling/doctype/quotation/test_quotation.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ def test_make_sales_order(self):
self.assertEqual(sales_order.get("items")[0].prevdoc_docname, quotation.name)
self.assertEqual(sales_order.customer, "_Test Customer")

sales_order.delivery_date = "2014-01-01"
sales_order.naming_series = "_T-Quotation-"
sales_order.transaction_date = nowdate()
sales_order.insert()
Expand Down Expand Up @@ -132,7 +131,6 @@ def test_make_sales_order_with_terms(self):
self.assertEqual(sales_order.get("items")[0].prevdoc_docname, quotation.name)
self.assertEqual(sales_order.customer, "_Test Customer")

sales_order.delivery_date = "2014-01-01"
sales_order.naming_series = "_T-Quotation-"
sales_order.transaction_date = nowdate()
sales_order.insert()
Expand Down

0 comments on commit 866df9f

Please sign in to comment.