refactor: adopt new and shiny document caster

erpnext/accounts/doctype/payment_entry/payment_entry.py

@@ -1170,28 +1170,25 @@ def set_remarks(self):
 
 		self.set("remarks", "\n".join(remarks))
 
-	def make_payment_entry(
-		self,
-		dt,
-		dn,
-		party_amount=None,
-		bank_account=None,
-		bank_amount=None,
-		party_type=None,
-		payment_type=None,
-		reference_date=None,
-	):
+	def _from_sales_order(self, so):
 		frappe.flags.new_payment_entry = self
-		return get_payment_entry(
-			dt,
-			dn,
-			party_amount=None,
-			bank_account=None,
-			bank_amount=None,
-			party_type=None,
-			payment_type=None,
-			reference_date=None,
-		)
+		return get_payment_entry(so.doctype, so.name)
+
+	def _from_sales_invoice(self, si):
+		frappe.flags.new_payment_entry = self
+		return get_payment_entry(si.doctype, si.name)
+
+	def _from_purchase_order(self, po):
+		frappe.flags.new_payment_entry = self
+		return get_payment_entry(po.doctype, po.name)
+
+	def _from_purchase_invoice(self, pi):
+		frappe.flags.new_payment_entry = self
+		return get_payment_entry(pi.doctype, pi.name)
+
+	def _from_dunning(self, d):
+		frappe.flags.new_payment_entry = self
+		return get_payment_entry(d.doctype, d.name)
 
 	def build_gl_map(self):
 		if self.payment_type in ("Receive", "Pay") and not self.get("party_account_field"):
@@ -2413,7 +2410,7 @@ def get_payment_entry(
 		if doc.doctype in (
 			"Sales Invoice",
 			"Purchase Invoice",
-			"Purchase Order",
+			"Purchase Orde",
 			"Sales Order",
 		) and frappe.get_cached_value(
 			"Payment Terms Template",

erpnext/selling/doctype/sales_order/sales_order.py

@@ -741,8 +741,8 @@ def cancel_stock_reservation_entries(self, sre_list=None, notify=True) -> None:
 			voucher_type=self.doctype, voucher_no=self.name, sre_list=sre_list, notify=notify
 		)
 
-	def make_sales_invoice(self, target_doc=None, ignore_permissions=False):
-		make_sales_invoice(self.name, target_doc, ignore_permissions)
+	def _into_sales_invoice(self):
+		make_sales_invoice(self.name)
 
 
 def get_unreserved_qty(item: object, reserved_qty_details: dict) -> float: