Skip to content

Commit

Permalink
Merge pull request #39764 from rohitwaghchaure/fixed-remove-file-from…
Browse files Browse the repository at this point in the history
…-disk-9515

fix: remove file from the disk after the completion of reposting
  • Loading branch information
rohitwaghchaure authored Feb 6, 2024
2 parents 40ce0c8 + 76b57a4 commit d6d9125
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ def repost(doc):
repost_gl_entries(doc)

doc.set_status("Completed")
remove_attached_file(doc.name)

except Exception as e:
if frappe.flags.in_test:
Expand Down Expand Up @@ -309,6 +310,13 @@ def repost(doc):
frappe.db.commit()


def remove_attached_file(docname):
if file_name := frappe.db.get_value(
"File", {"attached_to_name": docname, "attached_to_doctype": "Repost Item Valuation"}, "name"
):
frappe.delete_doc("File", file_name, delete_permanently=True)


def repost_sl_entries(doc):
if doc.based_on == "Transaction":
repost_future_sle(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -420,3 +420,38 @@ def test_repost_item_valuation_for_closing_stock_balance(self):

self.assertRaises(frappe.ValidationError, riv.save)
doc.cancel()

def test_remove_attached_file(self):
item_code = make_item("_Test Remove Attached File Item", properties={"is_stock_item": 1})

make_purchase_receipt(
item_code=item_code,
qty=1,
rate=100,
)

pr1 = make_purchase_receipt(
item_code=item_code,
qty=1,
rate=100,
posting_date=add_days(today(), days=-1),
)

if docname := frappe.db.exists("Repost Item Valuation", {"voucher_no": pr1.name}):
self.assertFalse(
frappe.db.get_value(
"File",
{"attached_to_doctype": "Repost Item Valuation", "attached_to_name": docname},
"name",
)
)
else:
repost_entries = create_item_wise_repost_entries(pr1.doctype, pr1.name)
for entry in repost_entries:
self.assertFalse(
frappe.db.get_value(
"File",
{"attached_to_doctype": "Repost Item Valuation", "attached_to_name": entry.name},
"name",
)
)

0 comments on commit d6d9125

Please sign in to comment.