Skip to content

Commit

Permalink
Merge pull request #38174 from frappe/mergify/bp/version-15-hotfix/pr…
Browse files Browse the repository at this point in the history
…-38147

fix: issue occured when creating supplier with contact details (#38147)
  • Loading branch information
deepeshgarg007 authored Nov 19, 2023
2 parents cf7d0ab + c29bc8c commit fc1ee1b
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions erpnext/selling/doctype/customer/customer.py
Original file line number Diff line number Diff line change
Expand Up @@ -644,8 +644,12 @@ def make_contact(args, is_primary_contact=1):
"is_primary_contact": is_primary_contact,
"links": [{"link_doctype": args.get("doctype"), "link_name": args.get("name")}],
}
if args.customer_type == "Individual":
first, middle, last = parse_full_name(args.get("customer_name"))

party_type = args.customer_type if args.doctype == "Customer" else args.supplier_type
party_name_key = "customer_name" if args.doctype == "Customer" else "supplier_name"

if party_type == "Individual":
first, middle, last = parse_full_name(args.get(party_name_key))
values.update(
{
"first_name": first,
Expand All @@ -656,9 +660,10 @@ def make_contact(args, is_primary_contact=1):
else:
values.update(
{
"company_name": args.get("customer_name"),
"company_name": args.get(party_name_key),
}
)

contact = frappe.get_doc(values)

if args.get("email_id"):
Expand Down Expand Up @@ -687,10 +692,12 @@ def make_address(args, is_primary_address=1, is_shipping_address=1):
title=_("Missing Values Required"),
)

party_name_key = "customer_name" if args.doctype == "Customer" else "supplier_name"

address = frappe.get_doc(
{
"doctype": "Address",
"address_title": args.get("customer_name"),
"address_title": args.get(party_name_key),
"address_line1": args.get("address_line1"),
"address_line2": args.get("address_line2"),
"city": args.get("city"),
Expand Down

0 comments on commit fc1ee1b

Please sign in to comment.