Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: company is ambiguous #36898

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Sep 1, 2023

image

To replicate:
Create a custom field company in Item and check the item-wise sales/purchase register report

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #36898 (3e1065a) into develop (0d26f67) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #36898      +/-   ##
===========================================
- Coverage    65.42%   65.42%   -0.01%     
===========================================
  Files          794      794              
  Lines        62194    62194              
===========================================
- Hits         40692    40689       -3     
- Misses       21502    21505       +3     
Files Changed Coverage
...e_purchase_register/item_wise_purchase_register.py ø
...em_wise_sales_register/item_wise_sales_register.py ø

@deepeshgarg007 deepeshgarg007 merged commit 39b598e into frappe:develop Sep 1, 2023
1 check passed
@rtdany10
Copy link
Contributor Author

rtdany10 commented Sep 1, 2023

@deepeshgarg007 backport also please?

@rtdany10
Copy link
Contributor Author

rtdany10 commented Sep 6, 2023

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

backport version-14-hotfix

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@rtdany10
Copy link
Contributor Author

rtdany10 commented Sep 6, 2023

@deepeshgarg007 please backport

@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Sep 6, 2023
deepeshgarg007 added a commit that referenced this pull request Sep 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants