Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: payment recon not showing payment entry when party_type is Student #36920

Merged

Conversation

RitvikSardana
Copy link
Member

When we select party_type as "Student" in Payment Reconcilliation, we don't get Payment Entries for the same.

Reason:
Only Customer and Supplier cases were dealt and not of Student.

Solution:
based on account_type the query is altered instead of hard coding it to either customer or supplier

@ruthra-kumar ruthra-kumar self-assigned this Sep 3, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #36920 (c4931cc) into develop (75d95ac) will decrease coverage by 0.01%.
Report is 20 commits behind head on develop.
The diff coverage is 80.02%.

@@             Coverage Diff             @@
##           develop   #36920      +/-   ##
===========================================
- Coverage    65.55%   65.55%   -0.01%     
===========================================
  Files          796      796              
  Lines        62717    62718       +1     
===========================================
- Hits         41114    41113       -1     
- Misses       21603    21605       +2     
Files Changed Coverage
...e/payment_reconciliation/payment_reconciliation.py ø
erpnext/assets/doctype/asset/asset.py 0.00%
...ctype/asset_capitalization/asset_capitalization.py ø
...ctype/stock_reconciliation/stock_reconciliation.py ø
...rpnext/stock/report/stock_balance/stock_balance.py ø
...next/stock/report/reserved_stock/reserved_stock.py 46.66%
...ext/stock/doctype/stock_settings/stock_settings.py 50.00%
erpnext/controllers/accounts_controller.py 56.25%
erpnext/stock/doctype/pick_list/pick_list.py 56.86%
erpnext/stock/stock_ledger.py 66.66%
... and 16 more

@ruthra-kumar ruthra-kumar merged commit d2f03c8 into frappe:develop Sep 5, 2023
12 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Sep 5, 2023
mergify bot pushed a commit that referenced this pull request Sep 5, 2023
…nt (#36920)

* fix: payment recon not showing payment entry when party_type is Student

* chore: code cleanup

* fix: payment recon based on account_type which is fetched from Party Type master

(cherry picked from commit d2f03c8)

# Conflicts:
#	erpnext/accounts/party.py
#	erpnext/controllers/accounts_controller.py
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants