item group filter shown parent and its child group items #37254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nandhinidevi123
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
| ): | ||
| if filters.get(opts[0]): | ||
| conditions += opts[1] | ||
| if filters.get("item_group"): |
There was a problem hiding this comment.
@Nandhinidevi123 A better way to do this would be https://github.com/frappe/erpnext/blob/develop/erpnext/accounts/report/financial_statements.py#L591
Also, the code is not formatted, please setup linters locally by referring https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist#linting and then reopen the PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before =>In the item-wise purchase register, When using the item group filter for a search, only the parent item group values were displayed, and the corresponding child group values were not shown.
After => Now, when searching for an item group, both the parent item group and its child group values are displayed.