-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AP AR filters from Party link #37268
Merged
ruthra-kumar
merged 7 commits into
frappe:develop
from
GursheenK:ar-summary-party-filter
Sep 28, 2023
Merged
fix: AP AR filters from Party link #37268
ruthra-kumar
merged 7 commits into
frappe:develop
from
GursheenK:ar-summary-party-filter
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GursheenK
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
September 27, 2023 07:51
Codecov Report
@@ Coverage Diff @@
## develop #37268 +/- ##
===========================================
+ Coverage 66.69% 66.70% +0.01%
===========================================
Files 794 794
Lines 62497 62541 +44
===========================================
+ Hits 41681 41721 +40
- Misses 20816 20820 +4
|
deepeshgarg007
added a commit
that referenced
this pull request
Sep 28, 2023
…-37268 fix: AP AR filters from Party link (backport #37268)
@GursheenK Impress with multiselect with customer. it will be good if this feature enabled for customer group too |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The AP & AR reports consist of the Party Type filter which is a Link field and Party filter which is a Dynamic Link field. However, the
set_route
function does not auto-populate the values for these field types even when the filter values are set in the parameters. So when a Supplier / Customer document is opened and the View Accounts Payable or View Accounts Receivable button is clicked, the report shows the entries for all suppliers / customers instead of the selected one.Screen.Recording.2023-09-27.at.2.14.45.PM.mov
Solution
Closes #37258
no-docs