refactor: In Quotation Item, discount_and_margin section should have same collapsible_depends_on as other similar DocType (Sales Order Item,Sales Invoice Item,...) #37272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…same collapsible_depends_on as other similar DocType (Sales Order Item,Sales Invoice Item,...)
FHenry
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
|
🎉 This PR is included in version 14.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually on Quotation Item when you fill a discount % or choose a margin type, the section collapse on blur event
Set the same collapsible_depends_on
eval: doc.margin_type || doc.discount_amount
on Quotation Item, field: discount_and_margin
as it is already the case on
"Sales Invoice Item": field discount_and_margin
"Purchase Order Item": field discount_and_margin_section
"Purchase Receipt Item": field discount_and_margin_section
"Delivery Note Item":field discount_and_margin
"Sales Order Item":field discount_and_margin
backport of #37252