Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Start and Last Fields on Work History Table #37276

Closed
wants to merge 1 commit into from

Conversation

kalungia
Copy link
Contributor

Added fields to hold the Start and Last Date of the employee's work history, instead of making it Date field Type, I made it Data so that one can enter Nov 2002 as most employees will forget the actual date they joined or left a company.

Added fields to hold the Start and Last Date of the employee's work history, instead of making it Date field Type, I made it Data so that one can enter Nov 2002 as most employees will forget the actual date they joined or left a company.
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #37276 (165d38a) into develop (62ea097) will increase coverage by 0.00%.
Report is 45 commits behind head on develop.
The diff coverage is 85.00%.

@@           Coverage Diff            @@
##           develop   #37276   +/-   ##
========================================
  Coverage    66.69%   66.70%           
========================================
  Files          794      794           
  Lines        62497    62541   +44     
========================================
+ Hits         41681    41716   +35     
- Misses       20816    20825    +9     
Files Coverage Δ
...ement_of_accounts/process_statement_of_accounts.py 58.54% <ø> (ø)
...ounts/doctype/purchase_invoice/purchase_invoice.py 83.95% <100.00%> (+0.28%) ⬆️
...post_accounting_ledger/repost_accounting_ledger.py 100.00% <100.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 83.95% <100.00%> (+0.07%) ⬆️
erpnext/controllers/subcontracting_controller.py 88.82% <ø> (ø)
...ext/manufacturing/doctype/work_order/work_order.py 80.32% <100.00%> (+0.13%) ⬆️
erpnext/projects/doctype/project/project.py 50.00% <100.00%> (ø)
erpnext/stock/stock_ledger.py 84.31% <100.00%> (-0.07%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 84.10% <73.33%> (-1.81%) ⬇️
erpnext/controllers/accounts_controller.py 84.85% <75.00%> (-0.40%) ⬇️

... and 1 file with indirect coverage changes

@stale
Copy link

stale bot commented Oct 13, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 13, 2023
@deepeshgarg007
Copy link
Member

@kalungia This doesn't seems necessary for core, there are joining and relieving date already, closing the PR.

@kalungia
Copy link
Contributor Author

@deepeshgarg007 it is necessary as a business person it is important to know when your employee started work from the previous companies and when they last exited.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants