Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sales uom and purchase uom in stock ledger #37387

Closed
wants to merge 9 commits into from

Conversation

Dilshanavs
Copy link

@Dilshanavs Dilshanavs commented Oct 7, 2023

A new filter "Select UOM" added in Stock Ledger Report. In this filter we can select Default UOM, Sales UOM and Purchase UOM..
Result of selecting 'Default UOM':
image

Sales UOM:
image

Purchase UOM:
image

no-doc

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Oct 7, 2023
@bosue
Copy link
Contributor

bosue commented Oct 7, 2023

Looks like this is an alternative implementation of something like #37332? Reusing the already existing UoMs (default, purchase, sales) seems quite a bit leaner and cleaner than adding yet another one.

But we all will have to figure out the details. I have to admit it’s a bit hard to grasp. Unsure if any of these is currently possible, but if yes, we might want to either use two levels of table headings for the pairs of columns or combine both UoM and qty into a single field. The latter is what we‘re doing in many currency fields, so that concept should be expandable.

Copy link
Contributor

@rtdany10 rtdany10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erpnext/stock/report/stock_ledger/stock_ledger.py Outdated Show resolved Hide resolved
erpnext/stock/report/stock_ledger/stock_ledger.py Outdated Show resolved Hide resolved
erpnext/stock/report/stock_ledger/stock_ledger.py Outdated Show resolved Hide resolved
erpnext/stock/report/stock_ledger/stock_ledger.py Outdated Show resolved Hide resolved
@Dilshanavs
Copy link
Author

@rohitwaghchaure

erpnext/stock/report/stock_ledger/stock_ledger.js Outdated Show resolved Hide resolved
erpnext/stock/report/stock_ledger/stock_ledger.js Outdated Show resolved Hide resolved
erpnext/stock/report/stock_ledger/stock_ledger.py Outdated Show resolved Hide resolved
erpnext/stock/report/stock_ledger/stock_ledger.py Outdated Show resolved Hide resolved
@Dilshanavs
Copy link
Author

@rohitwaghchaure

@Dilshanavs
Copy link
Author

@s-aga-r

@rtdany10
Copy link
Contributor

rtdany10 commented Nov 29, 2023

@Dilshanavs mark comments as resolved if you have made the requested changes. Also run pre-commit.

@s-aga-r
Copy link
Contributor

s-aga-r commented Dec 3, 2023

The test is failing and seems related.

@Dilshanavs
Copy link
Author

@s-aga-r

@Dilshanavs Dilshanavs requested review from s-aga-r and bosue December 14, 2023 08:55
@Dilshanavs
Copy link
Author

@s-aga-r

@Dilshanavs
Copy link
Author

@rohitwaghchaure
@s-aga-r

Copy link

stale bot commented Jan 12, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jan 12, 2024
@rtdany10
Copy link
Contributor

@stale stale bot removed the inactive label Jan 12, 2024
Copy link

stale bot commented Jan 28, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jan 28, 2024
@stale stale bot closed this Feb 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
@stale stale bot removed the inactive label Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants