-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sales uom and purchase uom in stock ledger #37387
Conversation
Looks like this is an alternative implementation of something like #37332? Reusing the already existing UoMs (default, purchase, sales) seems quite a bit leaner and cleaner than adding yet another one. But we all will have to figure out the details. I have to admit it’s a bit hard to grasp. Unsure if any of these is currently possible, but if yes, we might want to either use two levels of table headings for the pairs of columns or combine both UoM and qty into a single field. The latter is what we‘re doing in many currency fields, so that concept should be expandable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dilshanavs mark comments as resolved if you have made the requested changes. Also run pre-commit. |
The test is failing and seems related. |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
A new filter "Select UOM" added in Stock Ledger Report. In this filter we can select Default UOM, Sales UOM and Purchase UOM..
Result of selecting 'Default UOM':
Sales UOM:
Purchase UOM:
no-doc