Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payments): early error if payment request is invalid #37503

Closed
wants to merge 6 commits into from
Closed

fix(payments): early error if payment request is invalid #37503

wants to merge 6 commits into from

Conversation

blaggacao
Copy link
Collaborator

Context

  • As a users, create a Payment Request with an invalid datum in terms of the chosen payment gateway

Current Behaviour

  • Silently, no payment url is created

Desired Behaviour

  • The user is informed early about the invalid payment request on this particular gateway

Proposed Solution

  • Don't silence exceptions that where meant to bubble up to the user

Impact / Migration

Calling sites which dependent on a truthy value need to be refactored and cast exceptions themselves, if that's what they want to do.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 14, 2023
@blaggacao blaggacao force-pushed the fix/payment-gateway-validation-hook branch from 0e8f1ef to 31bbdf2 Compare October 14, 2023 08:49
This was referenced Oct 14, 2023
Merged
Merged
@blaggacao
Copy link
Collaborator Author

needs backport to v15

@blaggacao
Copy link
Collaborator Author

blaggacao commented Oct 26, 2023 •
edited
Loading

@s-aga-r I beleive this PR survived the refactorings unaltered.

@s-aga-r
Copy link
Contributor

s-aga-r commented Oct 27, 2023

@blaggacao test is failing, please check

@blaggacao blaggacao force-pushed the fix/payment-gateway-validation-hook branch from 07a0f23 to af0e611 Compare October 30, 2023 16:43
@blaggacao blaggacao force-pushed the fix/payment-gateway-validation-hook branch from 9a16724 to 6d7475a Compare October 30, 2023 17:31
@blaggacao
Copy link
Collaborator Author

superseded by frappe/payments#53

@blaggacao blaggacao closed this Nov 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaggacao @s-aga-r