Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): project test case #37541

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(test): project test case #37541

merged 1 commit into from
Oct 17, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Oct 17, 2023 

======================================================================
 FAIL  test_project_template_having_parent_child_tasks (erpnext.projects.doctype.project.test_project.TestProject.test_project_template_having_parent_child_tasks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/frappe-bench/apps/erpnext/erpnext/projects/doctype/project/test_project.py", line 91, in test_project_template_having_parent_child_tasks
    self.assertEqual(getdate(tasks[0].exp_end_date), calculate_end_date(project, 1, 10))
    project = <Project: PROJ-0002>
    project_name = 'Test Project with Template - Tasks with Parent-Child Relation'
    self = <erpnext.projects.doctype.project.test_project.TestProject testMethod=test_project_template_having_parent_child_tasks>
    task1 = <Task: TASK-2023-00005>
    task2 = <Task: TASK-2023-00006>
    task3 = <Task: TASK-2023-00007>
    tasks = [{'subject': 'Test Template Task Parent', 'exp_end_date': datetime.date(2023, 10, 31), 'depends_on_tasks': 'TASK-2023-00009,TASK-2023-00010,', 'name': 'TASK-2023-00008', 'parent_task': None}, {'subject': 'Test Template Task Child 1', 'exp_end_date': datetime.date(2023, 10, 20), 'depends_on_tasks': '', 'name': 'TASK-2023-00009', 'parent_task': 'TASK-2023-00008'}, {'subject': 'Test Template Task Child 2', 'exp_end_date': datetime.date(2023, 10, 21), 'depends_on_tasks': '', 'name': 'TASK-2023-00010', 'parent_task': 'TASK-2023-00008'}]
    template = <ProjectTemplate: Test Project Template  - Tasks with Parent-Child Relation>
AssertionError: datetime.date(2023, 10, 31) != datetime.date(2023, 10, 27)

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Oct 17, 2023
@s-aga-r s-aga-r marked this pull request as ready for review October 17, 2023 08:43
@s-aga-r s-aga-r merged commit 9d687ca into frappe:develop Oct 17, 2023
10 of 12 checks passed
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
s-aga-r added a commit that referenced this pull request Oct 17, 2023
@mergify @s-aga-r
fix(test): project test case (backport #37541) (#37543)
e23710b 
fix(test): project test case

(cherry picked from commit fd6aee1)

Co-authored-by: s-aga-r <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Oct 19, 2023
@frappe-bot
chore(release): Bumped to Version 14.44.1
6931db9 
## [14.44.1](v14.44.0...v14.44.1) (2023-10-19)

### Bug Fixes

* billed_qty to show a sum of all invoiced qty from the purchase order item. (backport [#37539](#37539)) ([#37558](#37558)) ([ac7d6d6](ac7d6d6))
* consider received qty while creating SO -> MR (backport [#37414](#37414)) ([#37514](#37514)) ([1b94510](1b94510))
* don't set finance books if gross_purchase_amount is not set (backport [#37480](#37480)) ([#37482](#37482)) ([0590f21](0590f21))
* e-commerce permissions for address ([#37554](#37554)) ([022f85d](022f85d))
* german tranlations of "Is Return" ([f9b2355](f9b2355))
* GL Entries not getting created for PR Return (backport [#37513](#37513)) ([#37516](#37516)) ([c32258e](c32258e))
* **gp:** wrong `allocated_amount` on multi sales person invoice ([d266423](d266423))
* Incorrect vat amount in KSA VAT report ([44f7de0](44f7de0))
* inflated total amt in TDS report using back calculation ([78e22af](78e22af))
* Issues related to RFQ and Supplier Quotation on Portal (backport [#37565](#37565)) ([#37577](#37577)) ([e1504ef](e1504ef))
* keep customer/supplier website role by default ([76ef61c](76ef61c))
* keyerror on gl and pl comparision report ([6f143d3](6f143d3))
* payment entry count on supplier dashboard (backport [#37571](#37571)) ([#37575](#37575)) ([95abd79](95abd79))
* same Serial No get mapped while creating SO -> DN ([#37527](#37527)) ([5025850](5025850))
* serial and batch no get removed on save of return DN ([#37476](#37476)) ([f1814a1](f1814a1))
* Stock Reconciliation Insufficient Stock Error ([#37494](#37494)) ([9406ddb](9406ddb))
* **test:** project test case (backport [#37541](#37541)) ([#37543](#37543)) ([e23710b](e23710b))
* use `flt` to ignore TypeError ([#37481](#37481)) ([d2b22db](d2b22db))

### Performance Improvements

* index `dn_detail` in `Delivery Note Item` (backport [#37528](#37528)) ([#37530](#37530)) ([001c230](001c230))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-aga-r