fix(Employee): Delete user permission, if create permission is not checked

[niraj2477]

While creating or updating Employee, if Create User Permission is not checked, delete the user permission for that user.

fixes : frappe/hrms#643

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[niraj2477]

@ruchamahabal Any updates on this?

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[niraj2477]

@deepeshgarg007 Can you have a look at this PR?

[ruchamahabal]

I am not sure if this is how it should be fixed. Deleting existing user permission that was not created because of this checkbox should not be implicitly deleted. Its possible people explicitly went and created the user permissions. This will give the employee access to all the records which also seems like an unexpected behaviour.

UX fix for this needs more thought. Closing the PR for now