Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added a customer name and supplier name columns #37433 issue #37557

Merged
merged 14 commits into from
Nov 12, 2023
Merged

fix: added a customer name and supplier name columns #37433 issue #37557

merged 14 commits into from
Nov 12, 2023

Conversation

viralkansodiya
Copy link
Contributor

fixes: #37433

supplier name and customer name columns added based on buying setting and selling setting

@bosue because of some problem on my git account i have to close #37479

274605496-ad7aacbd-c1ed-4ba8-9730-1555d3f32778 (1)

274605496-ad7aacbd-c1ed-4ba8-9730-1555d3f32778

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 18, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #37557 (b59663c) into develop (2b02ef0) will increase coverage by 0.00%.
Report is 4 commits behind head on develop.
The diff coverage is 9.52%.

@@           Coverage Diff            @@
##           develop   #37557   +/-   ##
========================================
  Coverage    67.39%   67.40%           
========================================
  Files          755      755           
  Lines        60253    60304   +51     
========================================
+ Hits         40608    40645   +37     
- Misses       19645    19659   +14     
Files Coverage Δ
...xt/accounts/doctype/sales_invoice/sales_invoice.py 83.91% <100.00%> (+0.02%) ⬆️
...eport/address_and_contacts/address_and_contacts.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit ecc305d into frappe:develop Nov 12, 2023
13 of 14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Request to Add Supplier Name Column Dynamically in Address and Contact Report within Buying Module
3 participants