Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: provision to truncate remarks in General Ledger and Accounts Receivable/Payable reports #38159

Merged
merged 2 commits into from
Nov 20, 2023
Merged

refactor: provision to truncate remarks in General Ledger and Accounts Receivable/Payable reports #38159

merged 2 commits into from
Nov 20, 2023

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Nov 18, 2023 •
edited
Loading

Screenshot 2023-11-20 at 9 40 14 AM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 18, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2023 •
edited
Loading

Codecov Report

Merging #38159 (a9bf906) into develop (a5a5341) will increase coverage by 0.00%.
Report is 18 commits behind head on develop.
The diff coverage is 42.85%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #38159   +/-   ##
========================================
  Coverage    67.26%   67.26%           
========================================
  Files          757      757           
  Lines        60492    60500    +8     
========================================
+ Hits         40689    40698    +9     
+ Misses       19803    19802    -1
Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 89.68% <75.00%> (-0.15%) ⬇️
...t/accounts/report/general_ledger/general_ledger.py 70.00% <0.00%> (-0.46%) ⬇️

... and 4 files with indirect coverage changes

@ruthra-kumar ruthra-kumar force-pushed the provision_to_truncate_remarks branch from a759aa5 to a9bf906 Compare November 20, 2023 04:09
@ruthra-kumar ruthra-kumar removed the needs-tests This PR needs automated unit-tests. label Nov 20, 2023
@ruthra-kumar ruthra-kumar merged commit 7b2eacd into frappe:develop Nov 20, 2023
14 checks passed
This was referenced Nov 20, 2023
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Nov 20, 2023
@ruthra-kumar
Merge pull request #38197 from frappe/mergify/bp/version-15-hotfix/pr…
2186e1c 
…-38159

refactor: provision to truncate `remarks` in General Ledger and Accounts Receivable/Payable reports (backport #38159)
ruthra-kumar added a commit that referenced this pull request Nov 20, 2023
@ruthra-kumar
Merge pull request #38196 from frappe/mergify/bp/version-14-hotfix/pr…
bfb8552 
…-38159

refactor: provision to truncate `remarks` in General Ledger and Accounts Receivable/Payable reports (backport #38159)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ruthra-kumar