Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prevent rounding loss based validation error #38234

Merged

Conversation

ruthra-kumar
Copy link
Member

Test case for #37886

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #38234 (56e991b) into develop (fb06ad7) will decrease coverage by 0.01%.
Report is 31 commits behind head on develop.
The diff coverage is 64.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38234      +/-   ##
===========================================
- Coverage    67.26%   67.26%   -0.01%     
===========================================
  Files          757      757              
  Lines        60502    60505       +3     
===========================================
+ Hits         40698    40700       +2     
- Misses       19804    19805       +1     
Files Coverage Δ
erpnext/accounts/party.py 81.02% <ø> (ø)
erpnext/controllers/sales_and_purchase_return.py 87.18% <100.00%> (+0.04%) ⬆️
erpnext/controllers/taxes_and_totals.py 95.30% <100.00%> (ø)
erpnext/hooks.py 100.00% <ø> (ø)
...serial_and_batch_bundle/serial_and_batch_bundle.py 73.15% <ø> (ø)
erpnext/stock/report/item_prices/item_prices.py 94.80% <ø> (ø)
.../report/accounts_receivable/accounts_receivable.py 89.68% <75.00%> (ø)
erpnext/selling/doctype/customer/customer.py 76.48% <80.00%> (ø)
...t/accounts/report/general_ledger/general_ledger.py 70.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 9680edf into frappe:develop Nov 21, 2023
14 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 21, 2023
…-38234

test: prevent rounding loss based validation error (backport #38234)
ruthra-kumar added a commit that referenced this pull request Nov 21, 2023
…-38234

test: prevent rounding loss based validation error (backport #38234)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant