Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Negative Qty and Rates in SO/PO #38253

Merged

Conversation

marination
Copy link
Collaborator

@marination marination commented Nov 21, 2023

Port of #38252

Issue:

  • This is allowed in Sales and Purchase Orders
    Screenshot 2023-11-21 at 12 30 38 PM
  • The same isn't allowed via Update Items
    Screenshot 2023-11-21 at 1 18 13 PM
  • Similarly negative rates aren't allowed via Update Items either

Fix:

  • Make sure on SO/PO save the qty is validated
    Screenshot 2023-11-21 at 1 19 15 PM
  • Also, allow negative rates on Update Items and normal doc submission/save

@marination marination changed the title fix: Don't allow negative qty in SO/PO fix: Negative Qty and Rates in SO/PO Nov 22, 2023
@rohitwaghchaure rohitwaghchaure merged commit 50f3b01 into frappe:version-14-hotfix Nov 27, 2023
10 checks passed
frappe-pr-bot pushed a commit that referenced this pull request Nov 28, 2023
# [14.51.0](v14.50.0...v14.51.0) (2023-11-28)

### Bug Fixes

* Alert message and make sure invoice due dates are different for effective test ([0813f02](0813f02))
* allow on submit for child table fields ([d72fbe9](d72fbe9))
* annual income and expenses in digest ([7dce68b](7dce68b))
* check reposting settings before allowing editable si ([f777d24](f777d24))
* condition in other bundle utils ([e96ef73](e96ef73))
* create contact if existing customer doesn't have contact ([bb2aa90](bb2aa90))
* do not set repost flag without validating voucher ([3ad6d08](3ad6d08))
* filter bundle items based on disabled check ([8a3a068](8a3a068))
* fiscal year using future date ([b0aa4ef](b0aa4ef))
* has_product_bundle util to only check for enabled bundles ([fd19ac5](fd19ac5))
* job card overlap validation (backport [#38345](#38345)) ([#38347](#38347)) ([9cf8955](9cf8955))
* Merge conflicts ([e7183e3](e7183e3))
* Negative Qty and Rates in SO/PO ([#38253](#38253)) ([50f3b01](50f3b01))
* Payment Reco Issue and chart of account importer ([730a3bb](730a3bb))
* Re-add no.of rows split in alert message ([fb19e7f](fb19e7f))
* **regional:** item wise tax calc issue ([0448d56](0448d56))
* Server Error while creating Product Bundle (backport [#38377](#38377)) ([#38379](#38379)) ([ca6a788](ca6a788))
* skip disabled bundles for non-report utils ([445e9c9](445e9c9))
* skip fixed assets in parent ([5dcd806](5dcd806))
* stock availability not showing ([#38382](#38382)) ([3929cc3](3929cc3))
* validation for existing bundles ([ae960e7](ae960e7))

### Features

* add disabled field in product bundle ([8d5efc9](8d5efc9))
* new Report "Lost Quotations" ([#38309](#38309)) ([1773e31](1773e31))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants