Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optmize outstanding amount query #38257

Merged

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Nov 21, 2023

Optimize the Voucher outstanding amount calculation query.

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Nov 21, 2023
@ruthra-kumar ruthra-kumar force-pushed the optimize_ple_outstanding_query branch from 7de892c to 8b04c1d Compare November 22, 2023 04:30
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #38257 (8b04c1d) into develop (fb06ad7) will increase coverage by 0.00%.
Report is 46 commits behind head on develop.
The diff coverage is 73.68%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #38257   +/-   ##
========================================
  Coverage    67.26%   67.27%           
========================================
  Files          757      757           
  Lines        60502    60520   +18     
========================================
+ Hits         40698    40715   +17     
- Misses       19804    19805    +1     
Files Coverage Δ
erpnext/accounts/party.py 81.02% <ø> (ø)
erpnext/accounts/utils.py 73.33% <100.00%> (+0.16%) ⬆️
erpnext/controllers/sales_and_purchase_return.py 87.18% <100.00%> (+0.04%) ⬆️
erpnext/controllers/taxes_and_totals.py 95.30% <100.00%> (ø)
erpnext/hooks.py 100.00% <ø> (ø)
...serial_and_batch_bundle/serial_and_batch_bundle.py 73.15% <ø> (ø)
erpnext/stock/report/item_prices/item_prices.py 94.80% <ø> (ø)
.../report/accounts_receivable/accounts_receivable.py 89.68% <75.00%> (ø)
erpnext/selling/doctype/customer/customer.py 76.48% <80.00%> (ø)
...t/accounts/report/general_ledger/general_ledger.py 70.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit efd31a4 into frappe:develop Nov 23, 2023
14 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 23, 2023
…-38257

refactor: optmize outstanding amount query (backport #38257)
ruthra-kumar added a commit that referenced this pull request Nov 23, 2023
…-38257

refactor: optmize outstanding amount query (backport #38257)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant