Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize update_purchase_cost method #38298

Merged

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Nov 23, 2023

On large datasets, Purchase Invoice cancellation slows down due to update_purchase_costing method
Untitled

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #38298 (dd016e6) into develop (24fcd67) will increase coverage by 0.00%.
Report is 19 commits behind head on develop.
The diff coverage is 75.67%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #38298   +/-   ##
========================================
  Coverage    67.27%   67.27%           
========================================
  Files          757      757           
  Lines        60546    60572   +26     
========================================
+ Hits         40730    40749   +19     
- Misses       19816    19823    +7     
Files Coverage Δ
...ounts/doctype/purchase_invoice/purchase_invoice.py 84.46% <100.00%> (+0.16%) ⬆️
erpnext/assets/doctype/asset/depreciation.py 83.28% <50.00%> (ø)
erpnext/buying/doctype/supplier/supplier.py 68.57% <0.00%> (ø)
erpnext/projects/doctype/project/project.py 50.60% <73.33%> (+0.60%) ⬆️

... and 7 files with indirect coverage changes

@ruthra-kumar ruthra-kumar force-pushed the simplied_purchase_cost_update branch 2 times, most recently from d86a1a4 to 7b24b80 Compare November 24, 2023 04:34
@ruthra-kumar ruthra-kumar force-pushed the simplied_purchase_cost_update branch from 7b24b80 to dd016e6 Compare November 24, 2023 05:50
@ruthra-kumar ruthra-kumar merged commit 9d6a06a into frappe:develop Nov 24, 2023
12 of 13 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 24, 2023
…-38298

perf: optimize update_purchase_cost method  (backport #38298)
ruthra-kumar added a commit that referenced this pull request Nov 24, 2023
…-38298

perf: optimize update_purchase_cost method  (backport #38298)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant