-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: optimize update_purchase_cost method #38298
Merged
ruthra-kumar
merged 4 commits into
frappe:develop
from
ruthra-kumar:simplied_purchase_cost_update
Nov 24, 2023
Merged
perf: optimize update_purchase_cost method #38298
ruthra-kumar
merged 4 commits into
frappe:develop
from
ruthra-kumar:simplied_purchase_cost_update
Nov 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38298 +/- ##
========================================
Coverage 67.27% 67.27%
========================================
Files 757 757
Lines 60546 60572 +26
========================================
+ Hits 40730 40749 +19
- Misses 19816 19823 +7
|
ruthra-kumar
force-pushed
the
simplied_purchase_cost_update
branch
2 times, most recently
from
November 24, 2023 04:34
d86a1a4
to
7b24b80
Compare
ruthra-kumar
force-pushed
the
simplied_purchase_cost_update
branch
from
November 24, 2023 05:50
7b24b80
to
dd016e6
Compare
ruthra-kumar
requested review from
rohitwaghchaure and
s-aga-r
as code owners
November 24, 2023 05:50
ruthra-kumar
added
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
labels
Nov 24, 2023
This was referenced Nov 24, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Nov 24, 2023
…-38298 perf: optimize update_purchase_cost method (backport #38298)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 24, 2023
…-38298 perf: optimize update_purchase_cost method (backport #38298)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
needs-tests
This PR needs automated unit-tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On large datasets, Purchase Invoice cancellation slows down due to
update_purchase_costing
method