feat: new Report "Lost Quotations" #38309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add connection to Quotation
Add connection to Quotation
barredterra
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
barredterra
changed the title
barredterra
added
backport version-14-hotfix
barredterra
force-pushed
the
report-lost-quotations
branch
from
7585265 to
7324341
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38309 +/- ##
===========================================
- Coverage 67.27% 67.24% -0.04%
===========================================
Files 757 758 +1
Lines 60546 60603 +57
===========================================
+ Hits 40730 40750 +20
- Misses 19816 19853 +37
|
barredterra
commented
Nov 24, 2023
barredterra
commented
Nov 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
(cherry picked from commit 477d9fa)
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
(cherry picked from commit 477d9fa)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 25, 2023
…-38309 feat: new Report "Lost Quotations" (#38309)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 25, 2023
…-38309 feat: new Report "Lost Quotations" (#38309)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
# [15.4.0](v15.3.0...v15.4.0) (2023-11-28) ### Bug Fixes * allow on submit for child table fields ([ac7615a](ac7615a)) * annual income and expenses in digest ([ca2ad17](ca2ad17)) * check reposting settings before allowing editable si ([25bf475](25bf475)) * condition in other bundle utils ([e4d9ef1](e4d9ef1)) * create contact if existing customer doesn't have contact ([b1b065d](b1b065d)) * display all item rate stop messages (backport [#38289](#38289)) ([#38307](#38307)) ([99c1fbf](99c1fbf)) * do not set repost flag without validating voucher ([6a3c3b4](6a3c3b4)) * don't depreciate assets with no schedule on scrapping (backport [#38276](#38276)) ([#38293](#38293)) ([18613c5](18613c5)) * filter bundle items based on disabled check ([fb517e8](fb517e8)) * fiscal year using future date ([b9a1fac](b9a1fac)) * has_product_bundle util to only check for enabled bundles ([5c12872](5c12872)) * job card overlap validation (backport [#38345](#38345)) ([#38348](#38348)) ([d6fe7eb](d6fe7eb)) * make parameters of `create_subscription_process` optional (and other minor fixes) ([#38360](#38360)) ([721b429](721b429)) * Negative Qty and Rates in SO/PO (backport [#38252](#38252)) ([#38357](#38357)) ([14174df](14174df)) * no fstring in translation (backport [#38381](#38381)) ([#38387](#38387)) ([c101855](c101855)) * patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38264](#38264)) ([4c9890a](4c9890a)) * Payment Reco Issue and chart of account importer ([4699887](4699887)) * serial no status (backport [#38391](#38391)) ([#38397](#38397)) ([b65c225](b65c225)) * Server Error while creating Product Bundle (backport [#38377](#38377)) ([#38380](#38380)) ([922aef6](922aef6)) * skip disabled bundles for non-report utils ([3d46b32](3d46b32)) * skip fixed assets in parent ([314a91a](314a91a)) * Supplier `Primary Contact` (backport [#38268](#38268)) ([#38286](#38286)) ([37d1f1a](37d1f1a)) * **ux:** Sales Order Stock Reservation Dialog (backport [#38261](#38261)) ([#38344](#38344)) ([3cbe599](3cbe599)) * validation for existing bundles ([c0de9c0](c0de9c0)) ### Features * add Bank Transaction to connections in Journal and Payment Entry (backport [#38297](#38297)) ([#38301](#38301)) ([72647b8](72647b8)) * add disabled field in product bundle ([fcd53be](fcd53be)) * new Report "Lost Quotations" ([#38309](#38309)) ([ea2c348](ea2c348)) ### Performance Improvements * optimize total_purchase_cost update ([deed9f5](deed9f5))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
# [14.51.0](v14.50.0...v14.51.0) (2023-11-28) ### Bug Fixes * Alert message and make sure invoice due dates are different for effective test ([0813f02](0813f02)) * allow on submit for child table fields ([d72fbe9](d72fbe9)) * annual income and expenses in digest ([7dce68b](7dce68b)) * check reposting settings before allowing editable si ([f777d24](f777d24)) * condition in other bundle utils ([e96ef73](e96ef73)) * create contact if existing customer doesn't have contact ([bb2aa90](bb2aa90)) * do not set repost flag without validating voucher ([3ad6d08](3ad6d08)) * filter bundle items based on disabled check ([8a3a068](8a3a068)) * fiscal year using future date ([b0aa4ef](b0aa4ef)) * has_product_bundle util to only check for enabled bundles ([fd19ac5](fd19ac5)) * job card overlap validation (backport [#38345](#38345)) ([#38347](#38347)) ([9cf8955](9cf8955)) * Merge conflicts ([e7183e3](e7183e3)) * Negative Qty and Rates in SO/PO ([#38253](#38253)) ([50f3b01](50f3b01)) * Payment Reco Issue and chart of account importer ([730a3bb](730a3bb)) * Re-add no.of rows split in alert message ([fb19e7f](fb19e7f)) * **regional:** item wise tax calc issue ([0448d56](0448d56)) * Server Error while creating Product Bundle (backport [#38377](#38377)) ([#38379](#38379)) ([ca6a788](ca6a788)) * skip disabled bundles for non-report utils ([445e9c9](445e9c9)) * skip fixed assets in parent ([5dcd806](5dcd806)) * stock availability not showing ([#38382](#38382)) ([3929cc3](3929cc3)) * validation for existing bundles ([ae960e7](ae960e7)) ### Features * add disabled field in product bundle ([8d5efc9](8d5efc9)) * new Report "Lost Quotations" ([#38309](#38309)) ([1773e31](1773e31))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new Report "Lost Quotations"
Enable drilldown to individual Quotations