Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create delivery trip on draft notes #38559

Merged
merged 1 commit into from
May 2, 2024
Merged

feat: create delivery trip on draft notes #38559

merged 1 commit into from
May 2, 2024

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Dec 4, 2023 •
edited
Loading

#37307 wasn't intended for closure / abandonment.

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 4, 2023
@blaggacao
Copy link
Collaborator Author

@deepeshgarg007 I think you wanted to review this some time ago?

@stale stale bot added inactive and removed inactive labels Dec 30, 2023
@blaggacao blaggacao force-pushed the feat/create-delivery-trip-on-draft-notes branch from ee41512 to 21b449b Compare December 30, 2023 09:21
@stale stale bot added inactive and removed inactive labels Jan 16, 2024
@blaggacao blaggacao marked this pull request as draft February 1, 2024 15:19
@stale stale bot added the inactive label Feb 17, 2024
@stale stale bot closed this Feb 22, 2024
@blaggacao

This comment was marked as resolved.

Sign in to view
@barredterra barredterra reopened this Feb 22, 2024
@stale stale bot removed the inactive label Feb 22, 2024
@frappe frappe deleted a comment from stale bot Feb 22, 2024
@frappe frappe deleted a comment from stale bot Feb 22, 2024
@frappe frappe deleted a comment from stale bot Feb 22, 2024
@stale Stale
Copy link

stale bot commented Mar 10, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Mar 10, 2024
@blaggacao

This comment was marked as resolved.

Sign in to view
@stale stale bot removed the inactive label Mar 10, 2024
@blaggacao blaggacao force-pushed the feat/create-delivery-trip-on-draft-notes branch from a17d456 to a377e8a Compare March 12, 2024 22:43
@blaggacao blaggacao force-pushed the feat/create-delivery-trip-on-draft-notes branch 4 times, most recently from 172f664 to af9b2fe Compare March 29, 2024 23:31
@blaggacao blaggacao marked this pull request as ready for review March 29, 2024 23:31
@blaggacao

This comment was marked as outdated.

Sign in to view
@blaggacao blaggacao force-pushed the feat/create-delivery-trip-on-draft-notes branch from af9b2fe to 1e7e7a7 Compare April 2, 2024 19:19
@blaggacao blaggacao force-pushed the feat/create-delivery-trip-on-draft-notes branch from 1e7e7a7 to 36660f2 Compare April 2, 2024 19:22
@barredterra barredterra changed the title feat/create delivery trip on draft notes feat: create delivery trip on draft notes Apr 2, 2024
@blaggacao
Copy link
Collaborator Author

@deepeshgarg007 I fixed the oversight in CI that had escaped my local testing. From my side, this is ready to review/merge.

@stale Stale
Copy link

stale bot commented Apr 18, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Apr 18, 2024
@blaggacao
Copy link
Collaborator Author

This is not intended to be closed.

@stale stale bot removed the inactive label Apr 18, 2024
@blaggacao
Copy link
Collaborator Author

@s-aga-r @rohitwaghchaure could someone please help out and engage with this PR? Thanks!

@s-aga-r s-aga-r added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels May 2, 2024
@s-aga-r s-aga-r merged commit 61f5ebd into frappe:develop May 2, 2024
19 checks passed
mergify bot pushed a commit that referenced this pull request May 2, 2024
@blaggacao @mergify
feat: create delivery trip on draft notes (#38559)
87826d4 
feat: create draft delivery trips from draft delivery notes
(cherry picked from commit 61f5ebd)

# Conflicts:
#	erpnext/stock/doctype/delivery_note/delivery_note.json
#	erpnext/stock/doctype/delivery_note/delivery_note.py
@mergify mergify bot mentioned this pull request May 2, 2024
Closed
@blaggacao blaggacao deleted the feat/create-delivery-trip-on-draft-notes branch May 2, 2024 10:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r s-aga-r approved these changes

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@barredterra barredterra Awaiting requested review from barredterra

Assignees
No one assigned
Labels
backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blaggacao @barredterra @s-aga-r