-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : correct logic for overlap error #38798
fix : correct logic for overlap error #38798
Conversation
@VihangT test cases failing |
added 1 change as per linters error |
fixing overlap error logic with taking care of sequential time job cards in overlap job card list Added Provision if time_logs list is empty
Added 1 change after failing in Python Unit Test (2) where time_logs is empty and has_overlap() is called. |
@s-aga-r I did not change anything related to that. |
92d61eb
into
frappe:version-14-hotfix
🎉 This PR is included in version 14.58.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fixing overlap error logic with taking care of sequential time job cards in overlap job card list
To understand the scenario I have taken live example which is illustrated below.
Ideally PO-JOB01797 should save their time logs as can be seen below image but instead system is throwing an overlap error with mentioning overlap with PO-JOB00678.
When I run the same code for overlap I found the below mentioned job cards in overlap list.
Technically PO-JOB01797 was operated on different station than other mentioned Job Cards still it showed an error.
Here I am explaining my approach towards this:
My approach towards overlapping is