Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate account in Sales/Purchase Taxes and Charges Template (backport #39013) #39017

Merged
merged 1 commit into from
Dec 29, 2023
Merged

fix: Validate account in Sales/Purchase Taxes and Charges Template (backport #39013) #39017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions erpnext/controllers/accounts_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2398,6 +2398,7 @@ def validate_taxes_and_charges(tax):

def validate_account_head(idx, account, company, context=""):
account_company = frappe.get_cached_value("Account", account, "company")
is_group = frappe.get_cached_value("Account", account, "is_group")

if account_company != company:
frappe.throw(
Expand All @@ -2407,6 +2408,12 @@ def validate_account_head(idx, account, company, context=""):
title=_("Invalid Account"),
)

if is_group:
frappe.throw(
_("Row {0}: Account {1} is a Group Account").format(idx, frappe.bold(account)),
title=_("Invalid Account"),
)


def validate_cost_center(tax, doc):
if not tax.cost_center:
Expand Down
Loading