Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perf): replace account subquery with 'in' condition #39023

Merged

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Dec 29, 2023

Speed up get_party_adjustment_amounts method - replace subquery using join with simple in condition.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 29, 2023
@ruthra-kumar
Copy link
Member Author

Ignoring unrelated test failure in Assets

@ruthra-kumar ruthra-kumar merged commit 1b0d964 into frappe:develop Jan 1, 2024
12 of 14 checks passed
ruthra-kumar added a commit that referenced this pull request Jan 1, 2024
…-39023

refactor(perf): replace account subquery with 'in' condition (backport #39023)
ruthra-kumar added a commit that referenced this pull request Jan 1, 2024
…-39023

refactor(perf): replace account subquery with 'in' condition (backport #39023)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant