Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default_roles hook doesn't exist anymore #39032

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

blaggacao
Copy link
Collaborator

Context

The default_roles hook as described in https://frappeframework.com/docs/user/en/guides/portal-development/portal-roles doesn't exist anymore in Frappe.

Proposed Solution

  • Remove it's noop declaration
  • In order to not confuse people who read the code
  • Update the docs (which I seem not to be able to in this PR)

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 29, 2023
@blaggacao blaggacao force-pushed the clenaup/no-default-roles-anymore branch from a3aa7c8 to c9a4ae6 Compare December 29, 2023 13:49
@blaggacao blaggacao changed the title cleanup: default_roles hook doesn't exist anymore chore: default_roles hook doesn't exist anymore Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (33b631e) 60.03% compared to head (c9a4ae6) 60.10%.
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39032      +/-   ##
===========================================
+ Coverage    60.03%   60.10%   +0.06%     
===========================================
  Files          761      761              
  Lines        70122    70188      +66     
===========================================
+ Hits         42099    42184      +85     
+ Misses       28023    28004      -19     
Files Coverage Δ
...xt/accounts/doctype/sales_invoice/sales_invoice.py 74.49% <100.00%> (+0.01%) ⬆️
...next/accounts/doctype/subscription/subscription.py 77.97% <100.00%> (+0.25%) ⬆️
erpnext/controllers/sales_and_purchase_return.py 91.18% <100.00%> (+0.57%) ⬆️
erpnext/hooks.py 100.00% <ø> (ø)
erpnext/manufacturing/doctype/bom/bom.py 73.32% <100.00%> (+0.75%) ⬆️
...pnext/stock/doctype/delivery_note/delivery_note.py 66.39% <100.00%> (+0.05%) ⬆️
erpnext/stock/doctype/stock_entry/stock_entry.py 79.22% <100.00%> (-0.02%) ⬇️
erpnext/controllers/accounts_controller.py 85.27% <85.71%> (+<0.01%) ⬆️
...e/manufacturing_settings/manufacturing_settings.py 36.36% <0.00%> (-1.14%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 67.78% <80.00%> (+0.19%) ⬆️
... and 5 more

... and 1 file with indirect coverage changes

@ankush ankush merged commit 4f8a168 into frappe:develop Jan 1, 2024
14 checks passed
@blaggacao blaggacao deleted the clenaup/no-default-roles-anymore branch January 2, 2024 06:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants