Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enqueue demo data setup on setup complete #39043

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

vorasmit
Copy link
Collaborator

Issue

  • On setup complete, it tries to create tax templates for the company (From the India Compliance App) in Foreground
  • Simultaneously, it tries to create tax templates for Demo Company, causing QueryDeadlockError

Ref: https://trace.frappe.cloud/share/issue/36bcc8de6e214c5580552a2663bad8c6/

Fix

Enqueue generation of demo data on setup complete.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 30, 2023
@ankush ankush added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Dec 31, 2023
@ankush ankush merged commit 877cc72 into frappe:develop Dec 31, 2023
11 of 13 checks passed
mergify bot pushed a commit that referenced this pull request Dec 31, 2023
@vorasmit vorasmit deleted the setup-demo branch December 31, 2023 05:31
ankush pushed a commit that referenced this pull request Dec 31, 2023
)

fix: enqueue demo data setup on setup complete (#39043)

(cherry picked from commit 877cc72)

Co-authored-by: Smit Vora <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Jan 3, 2024
# [15.9.0](v15.8.3...v15.9.0) (2024-01-03)

### Bug Fixes

* auto fetch not working if bundle exists (backport [#39002](#39002)) ([#39004](#39004)) ([2e91934](2e91934))
* **DX:** capture tracebacks with context (backport [#39060](#39060)) ([#39063](#39063)) ([8ad7faf](8ad7faf))
* enqueue demo data setup on setup complete (backport [#39043](#39043)) ([#39044](#39044)) ([d8cf994](d8cf994))
* incorrect total when Accumulating values ([7c7c3c9](7c7c3c9))
* Multiple subscription fixes ([#39005](#39005)) ([5158884](5158884))
* non stock uom validation for serial and batch (backport [#39018](#39018)) ([#39026](#39026)) ([89d1069](89d1069))
* not able to cancel sales invoice (backport [#38979](#38979)) ([#38980](#38980)) ([f8625f3](f8625f3))
* on cancellation of document cancel the serial and batch bundle (backport [#39076](#39076)) ([#39082](#39082)) ([2e0abbd](2e0abbd))
* Opening balance in bank reconciliation tool ([#38977](#38977)) ([e0755f9](e0755f9))
* purchase return without item code not working (backport [#39014](#39014)) ([#39015](#39015)) ([2a390ac](2a390ac))
* remove bad defaults (backport [#38986](#38986)) ([#38988](#38988)) ([46035ed](46035ed))
* select options should dynamically load dimensions ([21f9001](21f9001))
* serial and batch bundle company mandatory error (backport [#38994](#38994)) ([#38999](#38999)) ([d2580be](d2580be))
* take quantity into account when setting asset's gross purchase amt (backport [#39056](#39056)) ([#39058](#39058)) ([2e93275](2e93275))
* Unable to save Sales Invoice ([#39059](#39059)) ([73c0f37](73c0f37))
* undefined error in Budget Variance and Profitability report ([9fdf5c8](9fdf5c8))
* undefined error in consolidated financial report ([49f93f9](49f93f9))
* use `Stock Qty` while getting `POS Reserved Qty` (backport [#38962](#38962)) ([#38965](#38965)) ([76c6b50](76c6b50))
* Validate account in Sales/Purchase Taxes and Charges Template ([#39013](#39013)) ([f3254c2](f3254c2))
* work order with multi level, fetch operting cost from sub-assembly (backport [#38992](#38992)) ([#39028](#39028)) ([3a7506e](3a7506e))

### Features

* Against voucher filter in General Ledger ([#39102](#39102)) ([458064f](458064f))
* group by Asset in Asset Depreciations and Balances report (backport [#38923](#38923)) ([#39066](#39066)) ([d85dad7](d85dad7))
* Merge taxes from mapped docs ([#38346](#38346)) ([4e23048](4e23048))
* voucher subtype for general ledger ([#38822](#38822)) ([e5d73c7](e5d73c7))

### Performance Improvements

* index item_code in bom explosion item (backport [#39085](#39085)) ([#39088](#39088)) ([57bcf9f](57bcf9f))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants