fix: getting scrap items from sub assemblies by fetching scrap items for parent BOM #42928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KerollesFathy
requested review from
rohitwaghchaure and
s-aga-r
as code owners
|
@KerollesFathy Add test case |
|
@rohitwaghchaure, the test case has been added. Please review it. 🙏🏻 |
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
@KerollesFathy can you review this merge conflict and reopen the pull request |
KerollesFathy
requested review from
akhilnarang,
deepeshgarg007,
ruthra-kumar and
khushi8112
as code owners
KerollesFathy
force-pushed
the
Fix-BOM-Scrap
branch
2 times, most recently
from
144b5a5 to
f2e1610
Compare
KerollesFathy
force-pushed
the
Fix-BOM-Scrap
branch
from
f2e1610 to
8e33d93
Compare
|
@rohitwaghchaure Please review this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40658
Problem:
when creating a Stock Entry from a Work Order (click on finish button on Work Order and enter Qty for Manufacture and click Create). Specifically, when the "Set Operating Cost / Scrap Items From Sub-assemblies" option is enabled in Manufacturing Settings, the Stock Entry fails to correctly fetch the scrap items for BOM Item that on Work Order.
The problem occurs because the scrap items from sub-assemblies do not consider the BOM Scrap Item of the Parent BOM (fieldlabel : BOM No ) in the Work Order. This leads to incorrect stock entries.
How to reproduce the bug 🐛 :
Proposed Solution
This update will ensure that the Stock Entry accurately considers the Parent BOM's scrap items when generating stock entries from Work Orders.