Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong allocated_amount for sales_team in gross_profit report #42989

Conversation

devdiogenes
Copy link
Contributor

I created a single Sales Invoice with two items, both sold for 50.00 (total: 100.00). The current code shows a wrong allocated_amount, because for each item, it sums the total amount of the invoice, instead the item amount.

Before fixing:
before

After fixing:
after

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 29, 2024
Copy link

stale bot commented Sep 15, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Sep 15, 2024
@devdiogenes
Copy link
Contributor Author

Waiting review

@stale stale bot removed the inactive label Sep 16, 2024
Copy link

stale bot commented Oct 5, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 5, 2024
@devdiogenes
Copy link
Contributor Author

Waiting review

@stale stale bot removed the inactive label Oct 5, 2024
Copy link

stale bot commented Oct 29, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added inactive and removed inactive labels Oct 29, 2024
@devdiogenes
Copy link
Contributor Author

Waiting review

Copy link

stale bot commented Nov 16, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 16, 2024
@devdiogenes
Copy link
Contributor Author

Waiting for review

@stale stale bot removed the inactive label Nov 18, 2024
@ruthra-kumar ruthra-kumar self-assigned this Dec 3, 2024
@ruthra-kumar ruthra-kumar merged commit d2cab83 into frappe:develop Dec 13, 2024
13 checks passed
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Dec 13, 2024
…appe#42989)

* fix: Wrong allocated_amount for sales_team in gross_profit report

* style: Removes whitespaces

---------

Co-authored-by: ruthra kumar <[email protected]>
ruthra-kumar added a commit to ruthra-kumar/erpnext that referenced this pull request Dec 13, 2024
…appe#42989)

* fix: Wrong allocated_amount for sales_team in gross_profit report

* style: Removes whitespaces

---------

Co-authored-by: ruthra kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants