fix: remove invalid filter in Account Receivable report #44676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
approved these changes
Dec 13, 2024
ruthra-kumar
force-pushed
the
fix-ac-rec-pay,emt-term
branch
from
4fa56b5 to
578ca23
Compare
This was referenced Dec 13, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Dec 13, 2024
fix: remove invalid filter in Account Receivable report (backport #44676)
ruthra-kumar
added a commit
that referenced
this pull request
Dec 13, 2024
fix: remove invalid filter in Account Receivable report (backport #44676)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an invalid filter Account Receivable report was not generated correctly.
There is no such filter as
customerorsupplierin the Account Receivable/Payable Report. Due to this when the report is based on the payment term template, it was incorrect.Note:
The fix is required for backward compatibility.
The issue is not replicated locally because both payment_amount and base payment amount is set.
backport version-14
backport version-15
Frappe Support : https://support.frappe.io/app/hd-ticket/22249