Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Stripe's Price API for plan-price information (backport #26107) #45062

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 3, 2025

Stripe has reworked their API to create and manage subscriptions. Initially, we had to connect to the Plans API in order to manage plans (a combination of products and prices), but they've since reworked it to use the new Price API.

The Plans API is still backwards-compatible, but using the new API is a trivial change. I've also changed the fieldname in Subscription Plan to reflect the terms used in the Price API instead.


This is an automatic backport of pull request #26107 done by Mergify.

* fix: use Stripe's new Plan API for price information

* patch: use inbuilt function to rename field

* fix: patch call

Co-authored-by: Ankush Menat <[email protected]>
Co-authored-by: Nabin Hait <[email protected]>
(cherry picked from commit 16eed07)

# Conflicts:
#	erpnext/accounts/doctype/subscription_plan/subscription_plan.json
#	erpnext/erpnext_integrations/stripe_integration.py
#	erpnext/patches.txt
@mergify mergify bot requested a review from deepeshgarg007 as a code owner January 3, 2025 00:13
@mergify mergify bot added the conflicts label Jan 3, 2025
@mergify mergify bot requested a review from ruthra-kumar as a code owner January 3, 2025 00:13
Copy link
Contributor Author

mergify bot commented Jan 3, 2025

Cherry-pick of 16eed07 has failed:

On branch mergify/bp/version-13-hotfix/pr-26107
Your branch is up to date with 'origin/version-13-hotfix'.

You are currently cherry-picking commit 16eed07a0f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/subscription_plan/subscription_plan.json
	both modified:   erpnext/erpnext_integrations/stripe_integration.py
	both modified:   erpnext/patches.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants