Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduct tds on excess amount if checked (backport #45001) #45254

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 14, 2025

Issue: TDS gets deducted on the whole amount even if tax_on_excess_amount is checked in the tax withholding category.

If consider_party_ledger_amount is checked in the tax withholding category, the threshold is checked based on grand total of the invoice. But while checking tax_on_excess_amount, again threshold is checked based on the net amount of the invoice and if the threshold has not been breached tds is deducted from the whole amount.

Steps to replicate:

  • Create a tax withholding category with cumulative threshold 10,00,000/- and check tax_on_excess_amount and consider_party_ledger_amount.
  • Create a supplier with the above category.
  • Create a Purchase invoice with item amount 800000 and add taxes of 80,000.
  • Create another Purchase Invoice with item amount 130000.

Before:
TDS will be deducted on 9,30,000 even though tax_on_excess_amount is checked.

Solution:
Do not deduct tax if the threshold has not breached the net amount total.

After:
Tax will not be deducted because the threshold has not breached the net amount total.

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/28268

backport-version-15
backport-version-14


This is an automatic backport of pull request #45001 done by Mergify.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 14, 2025
@ruthra-kumar ruthra-kumar merged commit f897999 into version-15-hotfix Jan 14, 2025
12 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-45001 branch January 14, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants