fix: deduct tds on excess amount if checked (backport #45001) #45254
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: TDS gets deducted on the whole amount even if tax_on_excess_amount is checked in the tax withholding category.
If consider_party_ledger_amount is checked in the tax withholding category, the threshold is checked based on grand total of the invoice. But while checking tax_on_excess_amount, again threshold is checked based on the net amount of the invoice and if the threshold has not been breached tds is deducted from the whole amount.
Steps to replicate:
Before:
TDS will be deducted on 9,30,000 even though tax_on_excess_amount is checked.
Solution:
Do not deduct tax if the threshold has not breached the net amount total.
After:
Tax will not be deducted because the threshold has not breached the net amount total.
Frappe Support Issue: https://support.frappe.io/app/hd-ticket/28268
backport-version-15
backport-version-14
This is an automatic backport of pull request #45001 done by Mergify.