fix(Marketplace): don't show public link option to add app

also rename sidebar from `Apps` to `Marketplace`
frappe · Jul 4, 2024 · c94fbd1 · c94fbd1
1 parent d696de7
commit c94fbd1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/dashboard/src2/components/NavigationItems.vue b/dashboard/src2/components/NavigationItems.vue
@@ -85,7 +85,7 @@ export default {
 					disabled
 				},
 				{
-					name: 'Apps',
+					name: 'Marketplace',
 					icon: () => h(App),
 					route: '/apps',
 					isActive: routeName.startsWith('Marketplace'),

diff --git a/dashboard/src2/components/NewAppDialog.vue b/dashboard/src2/components/NewAppDialog.vue
@@ -234,13 +234,14 @@ export default {
 			tabs: [
 				{
 					label: 'Public GitHub App',
-					value: 'public-github-app'
+					value: 'public-github-app',
+					condition: () => !this.showVersionSelector
 				},
 				{
 					label: 'Your GitHub App',
 					value: 'your-github-app'
 				}
-			]
+			].filter(tab => tab.condition?.() ?? true)
 		};
 	},
 	watch: {