fix(agent): Ignore None responses on /info and /analytics endpoints

frappe · Jun 25, 2024 · fbbddfd · fbbddfd
1 parent b2ace9f
commit fbbddfd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/press/agent.py b/press/agent.py
@@ -943,13 +943,17 @@ def get_site_sid(self, site, user=None):
 		return result and result.get("sid")
 
 	def get_site_info(self, site):
-		return self.get(f"benches/{site.bench}/sites/{site.name}/info")["data"]
+		result = self.get(f"benches/{site.bench}/sites/{site.name}/info")
+		if result:
+			return result["data"]
 
 	def get_sites_info(self, bench, since):
 		return self.post(f"benches/{bench.name}/info", data={"since": since})
 
 	def get_site_analytics(self, site):
-		return self.get(f"benches/{site.bench}/sites/{site.name}/analytics")["data"]
+		result = self.get(f"benches/{site.bench}/sites/{site.name}/analytics")
+		if result:
+			return result["data"]
 
 	def get_sites_analytics(self, bench):
 		return self.get(f"benches/{bench.name}/analytics")

diff --git a/press/press/doctype/site/site.py b/press/press/doctype/site/site.py
@@ -1267,6 +1267,9 @@ def sync_info(self, data=None):
 		if not data:
 			data = self.fetch_info()
 
+		if not data:
+			return
+
 		fetched_usage = data["usage"]
 		fetched_config = data["config"]
 		fetched_timezone = data["timezone"]