Skip to content

Commit

Permalink
chore: added final modifier to BaseKpiCalculationStrategy
Browse files Browse the repository at this point in the history
- we don't permit to override our base implementation of `calculateKpi` and `isValid` to guarantee the usage of our common code
  • Loading branch information
janniclas committed Aug 26, 2024
1 parent 2123e3a commit 6d8aeda
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ internal abstract class BaseKpiCalculationStrategy : KpiCalculationStrategy {

abstract val kpiStrategyId: KpiStrategyId

override fun calculateKpi(
final override fun calculateKpi(
childScores: Collection<Pair<KpiCalculationResult, Double>>,
strict: Boolean
): KpiCalculationResult {
Expand Down Expand Up @@ -170,7 +170,7 @@ internal abstract class BaseKpiCalculationStrategy : KpiCalculationStrategy {
hasIncompleteResults: Boolean
): KpiCalculationResult

override fun isValid(node: KpiNode, strict: Boolean): Boolean {
final override fun isValid(node: KpiNode, strict: Boolean): Boolean {
if (node.kpiStrategyId != kpiStrategyId) {
return true
}
Expand Down

0 comments on commit 6d8aeda

Please sign in to comment.