TLC calculation #17
Merged
TLC calculation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously the adapter always returned an error result due to a missing explicit return statement - added version validation to make sure to always have valid semantic version strings
AnakinRaW
requested changes
Aug 30, 2024
adapter/src/main/kotlin/de/fraunhofer/iem/kpiCalculator/adapter/tools/tlc/model/TechnicalLag.kt
Outdated
Show resolved
Hide resolved
adapter/src/main/kotlin/de/fraunhofer/iem/kpiCalculator/adapter/tools/tlc/util/TimeHelper.kt
Outdated
Show resolved
Hide resolved
| isDefault = isDefault, | ||
| // this step harmonizes possibly weired version formats like 2.4 or 5 | ||
| // those are parsed to 2.4.0 and 5.0.0 | ||
| versionNumber = validateAndHarmonizeVersionString(versionNumber) |
There was a problem hiding this comment.
what about 4.0.0.0 ? In some ecosystems, while not recommened, it's allowed
There was a problem hiding this comment.
// Version parsing pattern: 1.2.3-alpha+build
internal const val VERSION_REGEX: String = "^$CORE_VERSION$PRE_RELEASE?$BUILD?\$"
// Prefixed version parsing pattern: v1.2-alpha+build
internal const val LOOSE_VERSION_REGEX: String = "^v?$LOOSE_CORE_VERSION$PRE_RELEASE?$BUILD?\$"
the regex from the semver library we use (and the semver standard) doesn't allow that and will fail with an invalid version exception (which we should probably catch so we don't crash due to one library with weired format)
adapter/src/main/kotlin/de/fraunhofer/iem/kpiCalculator/adapter/tools/tlc/TlcAdapter.kt
Outdated
Show resolved
Hide resolved
adapter/src/main/kotlin/de/fraunhofer/iem/kpiCalculator/adapter/tools/tlc/TlcAdapter.kt
Outdated
Show resolved
Hide resolved
adapter/src/main/kotlin/de/fraunhofer/iem/kpiCalculator/adapter/tools/tlc/TlcAdapter.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.