feat!: added adapter config to TlcAdapter #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
janniclas
commented
Sep 2, 2024
•
janniclas
commented
- removed KpiAdapter interface
- added configuration to TlcAdapter
- fixed missing recursive call in technical lag calculation
- added missing test cases
- breaking: removed KpiAdapter interface
- enables us to provide additional information for the calculated KPIs
AnakinRaW
approved these changes
Sep 3, 2024
|
|
||
| enum class ErrorType { DATA_VALIDATION_ERROR } | ||
|
|
||
| sealed class AdapterResult { | ||
| data class Success(val rawValueKpi: RawValueKpi) : AdapterResult() | ||
| sealed class Success(val rawValueKpi: RawValueKpi) : AdapterResult() { | ||
| class Kpi(rawValueKpi: RawValueKpi) : Success(rawValueKpi) |
There was a problem hiding this comment.
do you want these to be data classes?
There was a problem hiding this comment.
yes but it was complicated.. :D
the following code is not allowed:
data class Kpi(override val rawValueKpi: RawValueKpi) : Success(rawValueKpi)
as we may not have override modifiers in primary constructors. We also must only have val / var in primary constructors. So we can't do the pattern we do with a class class Kpi(rawValueKpi: RawValueKpi) : Success(rawValueKpi) and "hand down" the rawValueKpi to its superclass.
|
SupportedTools.kt was removed |
…ts before we can upload them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.