Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/max min strategy #31

Merged
merged 13 commits into from
Oct 30, 2024
Merged

Feature/max min strategy #31

merged 13 commits into from
Oct 30, 2024

Conversation

janniclas
Copy link
Contributor

@janniclas
feat: Updated WeightedMaximumKPICalculationStrategy behavior
24e64cd 
- we now calculate the weighted max as score * weight, but propagate the score
@janniclas
breaking: renaming
927ff5d 
 - renamed AggregationKPICalculationStrategy.kt to WeightedAverageKPICalculationStrategy.kt
 - renamed RatioKPICalculationStrategy.kt to WeightedRatioKPICalculationStrategy.kt
@janniclas
feat: added WeightedMinimumKPICalculationStrategy
9868f53
@janniclas janniclas self-assigned this Oct 28, 2024
@janniclas janniclas mentioned this pull request Oct 28, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
JUnit Test Report57 ran57 passed0 skipped0 failed

@janniclas janniclas added the enhancement New feature or request label Oct 28, 2024
@janniclas janniclas added this to the 0.0.3 milestone Oct 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Code Coverage

Overall Project 79.12% -2.79% 🍏
Files changed 73.99% ❌

Module Coverage
core 85.31% -6.22% ❌
adapter 74.09% 🍏
Files
Module File Coverage
core WeightedAverageKPICalculationStrategy.kt 97.1% 🍏
KpiCalculationStrategy.kt 94.38% -2.5% 🍏
WeightedRatioKPICalculationStrategy.kt 88.37% 🍏
MaximumKPICalculationStrategy.kt 59.09% -11.36% 🍏
MinimumKPICalculationStrategy.kt 55.68% -40.91% ❌
WeightedMaximumKPICalculationStrategy.kt 53.25% -12.99% 🍏
WeightedMinimumKPICalculationStrategy.kt 53.25% -42.86% ❌
adapter CveAdapter.kt 100% 🍏
TrivyAdapter.kt 94.2% 🍏

@janniclas janniclas dismissed AnakinRaW’s stale review October 30, 2024 14:33

Reviewed by Hutomo

@janniclas janniclas merged commit 7d8d122 into main Oct 30, 2024
2 checks passed
@janniclas janniclas deleted the feature/maxMinStrategy branch October 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutomosaleh hutomosaleh hutomosaleh approved these changes

@AnakinRaW AnakinRaW AnakinRaW left review comments

Assignees

@janniclas janniclas

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@janniclas @AnakinRaW @hutomosaleh