Differentiate between CODE and CONTAINER scan results #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage
Files
|
hutomosaleh
requested changes
Oct 30, 2024
adapter/src/main/kotlin/de/fraunhofer/iem/spha/adapter/kpis/cve/CveAdapter.kt
Outdated
Show resolved
Hide resolved
…fferentiate between container and code scanning results # Conflicts: # adapter/src/main/kotlin/de/fraunhofer/iem/spha/adapter/kpis/cve/CveAdapter.kt # model/src/main/kotlin/de/fraunhofer/iem/spha/model/kpi/hierarchy/DefaultHierarchy.kt
janniclas
force-pushed
the
feature/trivy
branch
from
45192ef
to
a6cb0c9
Compare
hutomosaleh
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even tho both, code scanning tools and container scanning tools, generate CVE results, we still need to differentiate between those two, due to domain requirements.
Thus, I created a dedicated CODE_VULNERABILITY and CONTAINER_VULNERABILITY KPI ID and modified the adapter code accordingly.