Design change #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done pretty much all I can comfortably do with the scouting system, so I should probably leave the rest to you and the others and take on more of an observatory role.
The main issue right are that we don't have the actual auton intake and that doing the programming for that would involve creating three arrays for each row of rings on the field plus a preload holder, which involves a lot of Redux and database stuff I don't feel comfortable doing. Also my dad was wondering if the center row of 5 rings is really necessary.
There's also the matter of the undo button, which also requires access to the data that I can't pull off myself. Dad also wondered if that was too much effort, so if all else fails we could just remove the undo buttons.
Finally, I don't actually have working data or know any methods to create one, so I can't do the actual testing right now. With the changes I made I likely broke a few things on the backend without knowing. Most of the front end logic aside from the aforementioned auton intake is in place though.
And if there's any time left over, keyboard shortcuts and changing some of my more sloppy UI work. I can handle that if necessary, but otherwise I'm probably going to listen in on you guys and some robot code stuff to make the last week and a half of build season more productive for me.