fix: allow brackets

fredrikaverpil · May 22, 2024 · 945f5a8 · 945f5a8
1 parent c0a34a5
commit 945f5a8
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/lua/neotest-golang/convert.lua b/lua/neotest-golang/convert.lua
@@ -12,11 +12,6 @@ function M.to_gotest_test_name(pos_id)
   test_name = test_name:gsub("::", "/")
   -- Remove double quotes (single quotes are supported)
   test_name = test_name:gsub('"', "")
-  -- Replace any special characters with . so to avoid breaking regexp
-  test_name = test_name:gsub("%[", ".")
-  test_name = test_name:gsub("%]", ".")
-  test_name = test_name:gsub("%(", ".")
-  test_name = test_name:gsub("%)", ".")
   -- Replace any spaces with _
   test_name = test_name:gsub(" ", "_")
 

diff --git a/tests/go/testname_spec.lua b/tests/go/testname_spec.lua
@@ -43,4 +43,21 @@ describe("Subtest name conversion", function()
       vim.inspect(actual_go_test_name)
     )
   end)
+
+  it("Brackets", function()
+    local expected_subtest_name = '"Brackets [1] (2) {3} are ok"'
+    local expected_gotest_name = "TestNames/Brackets_[1]_(2)_{3}_are_ok"
+
+    -- Act
+    local pos = tree:node(5):data()
+    local actual_go_test_name = convert.to_gotest_test_name(pos.id)
+
+    -- Assert
+    local actual_name = pos.name
+    assert.are.same(expected_subtest_name, actual_name)
+    assert.are.same(
+      vim.inspect(expected_gotest_name),
+      vim.inspect(actual_go_test_name)
+    )
+  end)
 end)
diff --git a/tests/go/testname_test.go b/tests/go/testname_test.go
@@ -15,4 +15,10 @@ func TestNames(t *testing.T) {
 			t.Fail()
 		}
 	})
+
+	t.Run("Brackets [1] (2) {3} are ok", func(t *testing.T) {
+		if Add(1, 2) != 3 {
+			t.Fail()
+		}
+	})
 }