Improve test detection for monorepos #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikaverpil
commented
May 12, 2024
| @@ -12,10 +12,8 @@ M.Adapter = { name = "neotest-golang" } | |||
| ---@param dir string @Directory to treat as cwd | |||
There was a problem hiding this comment.
Add missing type param for the depth.
fredrikaverpil
changed the title
fredrikaverpil
force-pushed
the
detect-monorepo
branch
4 times, most recently
from
5dd1e2a to
ee27ed2
Compare
fredrikaverpil
force-pushed
the
detect-monorepo
branch
from
ee27ed2 to
c55b75b
Compare
|
Closing this, as I realize it's likely better to just return the current cwd as the root dir. The reason is neotest-golang is setting the cwd for both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
Currently, if the folder in which you start neovim doesn't contain a
go.mod/go.sum, tests are not detected.What was done in this PR?
Search the folder tree for
go.mod/go.sumfiles and if found, return the current working folder as the root of the project. This causes tests to be found in neotest.Notes
Currently, a max depth of 100 is default, which is on the larger side. This could be set lower, and be configurable.