-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support luarocks/rocks.nvim #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrcjkb !
I'll read up on this subject and add the API key when I'm back from 🏖️🌴.
c873dde
to
f277b5b
Compare
dependencies: | | ||
neotest | ||
plenary.nvim | ||
tree-sitter-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... does this imply that this dependency should also be part of the current lazy.nvim instructions in the README?
I didn't quite understand if this was part of the upcoming changes to Neovim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, luarocks tree-sitter parsers currently only work with rocks.nvim.
lazy.nvim users will probably still want to use nvim-treesitter to install parsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks!
One more question. Lazy.nvim recently started supporting rockspecs: https://lazy.folke.io/packages#rockspec
Isn't that what gets uploaded to luarocks?
Would it make sense for me to create one and then direct this GitHub action to read it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lazy.nvim can install from luarocks if there's a rockspec in the repo root, but it doesn't treat luarocks packages as first class citizens, so it won't be able to use the tree-sitter-go dependency.
The Github action doesn't yet support using scm rockspecs as a template. See:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for these insights! 💡
I've now added the |
Hey 👋
Summary
This PR is part of a push to get neovim plugins on luarocks.org.
See also:
With luarocks/rocks.nvim, it is the plugin authors' responsibility to declare dependencies (including tree-sitter parsers) and build instructions - not the user's.
Installing this plugin becomes as simple as
:Rocks install neotest-go.nvim
.Things done:
See also: this guide
Notes:
Important
neovim
and/orvim
labels have to be added to the luarocks package manually (after the first upload), for this plugin to show up in https://luarocks.org/labels/neovim or https://luarocks.org/labels/vim, respectively.