Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show correct number of errors in diagnostics #20

Merged
merged 2 commits into from
May 22, 2024
Merged

Show correct number of errors in diagnostics #20

merged 2 commits into from
May 22, 2024

Conversation

fredrikaverpil
Copy link
Owner

@fredrikaverpil fredrikaverpil commented May 20, 2024 •
edited
Loading

Current behavior

image

An incorrect number of errors are reported to diagnostics:

image

Expected behavior

image

image

Todo

  • Verify test output window and output panel.
  • Check if panic handling is needed or if it can be removed.

@fredrikaverpil fredrikaverpil self-assigned this May 20, 2024
@fredrikaverpil fredrikaverpil changed the title Show right number of errors in diagnostics Show correct number of errors in diagnostics May 20, 2024
@fredrikaverpil fredrikaverpil marked this pull request as ready for review May 22, 2024 18:02
@fredrikaverpil fredrikaverpil merged commit 2e42066 into main May 22, 2024
7 checks passed
@fredrikaverpil fredrikaverpil deleted the fix-diagnostics branch May 22, 2024 18:03
@fredrikaverpil fredrikaverpil mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fredrikaverpil fredrikaverpil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fredrikaverpil