Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dap): debug files #203

Closed
wants to merge 2 commits into from
Closed

Conversation

hown3d
Copy link
Contributor

@hown3d hown3d commented Oct 13, 2024

Motiviation

Currently it's only supported to debug a specific test. This PR allows to start the debugger on a file.

Special notes for reviewer:

This PR is based on #202

Lukas Hoehl added 2 commits October 13, 2024 21:39
@fredrikaverpil
Copy link
Owner

Hey @hown3d 👋 and many thanks for this!

I'll have a thorough look at this during the coming days. Looks nice, from just having skimmed the diff.

Could you describe your use case of debugging a test file (instead of just a single test)?
Does the debugger run through each test?
I'm just curious, that's all 😄

@hown3d
Copy link
Contributor Author

hown3d commented Oct 13, 2024

Could you describe your use case of debugging a test file (instead of just a single test)? Does the debugger run through each test?

Yes, the debugger does execute all files. Use case would be for breakpoints on functions that are called from multiple tests.

@fredrikaverpil
Copy link
Owner

Sorry about this @hown3d I messed up and forgot to add you as co-author to the commit which I squash-merged. Anyhow, your changes are in! 🎉

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants