Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
If you add tests as part of
[packagename]_test
(an otherwise non-existingpackage),
go list -json
did not properly aid in mapping from filename to Gopackage, and cause the
go test
command to fall back to using./...
insteadof the desired package name. This become a problem if you want to run all tests
of a given file.
What was changed?
Not only look for the
TestGoFiles
key in the JSON output fromgo list -json
.Also look for the
XTestGoFiles
key.Notes
To do
TestGoFiles
vsXTestGoFiles
TestGoFiles
:tested.
*_test.go
that have the same package name as thesource files.
members.
XTestGoFiles
:[packagename]_test
.*_test.go
that have the package name[packagename]_test
.members.
Example:
fixes: #222